Hi! On Thu, Jun 21, 2018 at 03:32:25PM -0500, Aaron Sawdey wrote: > expand_strn_compare was not using gen_int_mode or trunc_int_for_mode to > properly truncate to Pmode when creating contants in the generate rtx. > This lead to an improper constant and the ICE in PR/86222. > > Testing on ppc64 with -m32, -m32 -mpowerpc64 and -m64. If regstrap > passes, ok for trunk and backport to 8?
Okay for trunk and also for 8. Nit: > + rtx len_rtx = gen_reg_rtx (Pmode); > + emit_move_insn (len_rtx, gen_int_mode (bytes-compare_length, Pmode)); Spaces around the - please. Thanks, Segher
