----- Am 14. Jun 2018 um 20:23 schrieb Jim Wilson j...@sifive.com:

> On Wed, Jun 13, 2018 at 9:57 PM, Sebastian Huber
> <sebastian.hu...@embedded-brains.de> wrote:
>> gcc/
>>         * config.gcc (riscv*-*-elf* | riscv*-*-rtems*): Use custom
>>         multilibs for *-*-rtems*.
>>         * config/riscv/t-rtems: New file.
> 
> Looks OK to me.  Though I think you can probably self approve patches
> like this that only affect the riscv*-*-rtems* port.

The change in config.gcc could break all RISC-V ports, e.g. some typo leading 
to a syntax error. I would like to back port this to GCC 7 and 8.

> 
> I notice that you don't have a MULTILIB_REUSE definition as in
> t-elf-multilib.   This means you are missing rv32gc and rv64gc
> support, which might be a problem as these are common configure and
> command line choices.  The t-elf-multilib file also uses these for a
> few other combinations like rv32ic, rv32imc and ilp32f/rv32gc to
> reduce the number of libraries built.

The machine flags are defined by the board support packages and the application 
must use them.

Reply via email to