Hi Nicolas,
a few other nits:
* The current patch has a large number of GNU Coding Style violations,
many catched by contrib/check_GNU_style.{sh,py}.
* Others are partially pre-existing (additional blank before formal
paramater name as in
+destroy_adv_cond (struct adv_cond * ac)
and many many more.
* Many of the new functions lack comments.
* Hardcoded escape codes in async.h.
* Several indentation and line length errors, like
+ if (au->tail)
+ internal_error(NULL, "Trying to free nonempty unit");
TAB instead of 4 spaces.
* Stuff like this in async.c at the very least needs a comment
explaining what's going on:
+#ifndef GTHREAD_USE_WEAK
+#ifdef SUPPORTS_WEAK
+#define GTHREAD_USE_WEAK 1
+#endif
+#endif
This should already be handled in gthr.h. Why not use that?
+#define _GTHREAD_USE_COND_INIT_FUNC
+#include "../../libgcc/gthr-posix.h"
Again: gthr.h would include that (via gthr-default.h) already.
As I stated, those are mostly nits, but should be fixed before this
patch goes in.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
