> This works nicely if the landing pad bb hasn't been really modified much,
> in particular it still needs to contain only the instructions emitted
> by expand_dw2_landing_pad_for_region function call and then an unconditional
> jump or at least single successor and nothing else in the bb.

How is that supposed to work for SJLJ though?

> 2018-04-13  Jakub Jelinek  <ja...@redhat.com>
> 
>       PR rtl-optimization/85393
>       * bb-reorder.c (fix_up_crossing_landing_pad): In new_bb emit just
>       a label and unconditional jump to old_bb, rather than
>       expand_dw2_landing_pad_for_region insn(s) and jump to single_succ
>       basic block.

OK, but also make expand_dw2_landing_pad_for_region private so that the same 
mistake is not made again in the future.

-- 
Eric Botcazou

Reply via email to