On Fri, Feb 23, 2018 at 11:32:57AM +0000, Ramana Radhakrishnan wrote: > This fixes a GCC-8 regression that we accidentally switched off frame > pointers in the AArch64 backend when changing the defaults in the common > parts of the code. This breaks an ABI decision that was made in GCC at > the dawn of the port with respect to having a frame pointer at all > times. If we really want to turn this off lets have a discussion around > that separately. > > For now turn this back on and I believe this will leave PR84521 latent > again with -fomit-frame-pointer and (hopefully) make the ruby issue go > away. I'm asking Sudi to pick that up. > > Bootstrapped and regression tested on AArch64-none-linux-gnu but I see > one regression in gcc.c-torture/execute/960419-2.c which needs to be > looked at next (PR84528, thanks Kyrill). > > Ok to put in and then look at PR84528 ?
OK. Are your testsuite chanmges just the revert of r254814, your ChangeLog should reflect that. Thanks, James > > gcc/ChangeLog: > > 2018-02-23 Ramana Radhakrishnan <ramana.radhakrish...@arm.com> > > PR target/84521 > * common/config/aarch64/aarch64-common.c > (aarch_option_optimization_table[]): Switch > off fomit-frame-pointer > > gcc/testsuite/ChangeLog: > > 2018-02-23 Ramana Radhakrishnan <ramana.radhakrish...@arm.com> > > * gcc.target/aarch64/lr_free_2.c: Adjust test. > * gcc.target/aarch64/spill_1.c: Likewise. > * gcc.target/aarch64/test_frame_11.c: Likewise. > * gcc.target/aarch64/test_frame_12.c: Likewise. > * gcc.target/aarch64/test_frame_13.c: Likewise. > * gcc.target/aarch64/test_frame_14.c: Likewise. > * gcc.target/aarch64/test_frame_15.c: Likewise. > * gcc.target/aarch64/test_frame_3.c: Likewise. > * gcc.target/aarch64/test_frame_5.c: Likewise. > * gcc.target/aarch64/test_frame_9.c: Likewise.
