On Tue, 2018-01-16 at 16:34 -0600, Segher Boessenkool wrote:
> Hi!
>
> On Tue, Jan 16, 2018 at 01:39:28PM -0600, Will Schmidt wrote:
> > Sniff-tests of the target tests on a single system look OK. Full regtests
> > are
> > currently running across assorted power systems.
> > OK for trunk, pending successful results?
>
> Just a few little things:
>
> > 2018-01-16 Will Schmidt <[email protected]>
> >
> > * config/rs6000/rs6000.c: (rs6000_gimple_builtin) Add gimple folding
> > support for merge[hl].
>
> The : goes after the ).
>
> > (define_insn "altivec_vmrghw_direct"
> > - [(set (match_operand:V4SI 0 "register_operand" "=v")
> > - (unspec:V4SI [(match_operand:V4SI 1 "register_operand" "v")
> > - (match_operand:V4SI 2 "register_operand" "v")]
> > - UNSPEC_VMRGH_DIRECT))]
> > + [(set (match_operand:V4SI 0 "register_operand" "=v,wa")
> > + (unspec:V4SI [(match_operand:V4SI 1 "register_operand" "v,wa")
> > + (match_operand:V4SI 2 "register_operand" "v,wa")]
> > + UNSPEC_VMRGH_DIRECT))]
> > "TARGET_ALTIVEC"
> > - "vmrghw %0,%1,%2"
> > + "@
> > + vmrghw %0,%1,%2
> > + xxmrghw %x0,%x1,%x2"
>
> Those last two lines should be indented one more space, so that everything
> aligns (with the @).
>
> > + "@
> > + vmrglw %0,%1,%2
> > + xxmrglw %x0,%x1,%x2"
>
> Same here of course.
>
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-be-folded.c
> > @@ -0,0 +1,11 @@
> > +/* { dg-do compile { target { powerpc-*-* } } } */
>
> Do you want powerpc*-*-*? That is default in gcc.target/powerpc; dg-do
> compile is default, too, so you can either say
>
> /* { dg-do compile } */
>
> or nothing at all, to taste.
>
> But it looks like you want to restrict to BE? We still don't have a
> dejagnu thingy for that; you could put some #ifdef around it all (there
> are some examples in other testcases). Not ideal, but works.
Just want to ensure continuing coverage. :-) This test in particular
is a copy/paste + tweak of an existing test, which tries to limit itself
to BE, there is an LE counterpart.
My regression test results suggest that the addition of the
-mno-fold-gimple option to the existing testcases appears to have
uncovered an ICE, so pausing for the moment...
(Power7 BE, gcc revision 256400, mergeh/mergel gimple folding patch applied)
spawn -ignore SIGHUP
/home/willschm/gcc/build/gcc-mainline-regtest_patches/gcc/xgcc
-B/home/willschm/gcc/build/gcc-mainline-regtest_patches/gcc/
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/testsuite/gcc.target/powerpc/builtins-1-be.c
-fno-diagnostics-show-caret -fdiagnostics-color=never -mcpu=power8 -O0
-mno-fold-gimple -ffat-lto-objects -S -m32 -mno-fold-gimple -o builtins-1-be.s
gimple folding of rs6000 builtins has been disabled.
during RTL pass: ira
In file included from
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/testsuite/gcc.target/powerpc/builtins-1-be.c:70:
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/testsuite/gcc.target/powerpc/builtins-1.h:
In function 'main':
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/testsuite/gcc.target/powerpc/builtins-1.h:229:1:
internal compiler error: in elimination_costs_in_insn, at reload1.c:3633
0x1089878f elimination_costs_in_insn
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/reload1.c:3630
0x108a0dc7 calculate_elim_costs_all_insns()
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/reload1.c:1607
0x106efc17 ira_costs()
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/ira-costs.c:2249
0x106e7533 ira_build()
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/ira-build.c:3421
0x106db30f ira
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/ira.c:5292
0x106db30f execute
/home/willschm/gcc/gcc-mainline-regtest_patches/gcc/ira.c:5603
