Re: [PATCH] ARM testsuite: force hardfp for addr-modes-float.c

[Kyrill Tkachov]

Hi Charles,

On 27/11/17 17:03, Charles Baylis wrote:
Some of the new tests in addr-modes-float.c, which were introduced for
the rework of addressing modes costs [1] fail when GCC is configured
to default to a softfp calling convention. Fix this by annotating the
test functions with __attribute__((pcs("aapcs-vfp"))).

The usual approach to this problem is to add an -mfloat-abi=hard to the 
dg-options
of the test (the tests are not dg-run, so there's no link-time mismatch 
concerns).
Any particular reason to use the pcs attribute instead?

Thanks,
Kyrill

Thanks to Christophe for pointing this out.

[1] https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02149.html

<date>  Charles Baylis  <charles.bay...@linaro.org>

         * gcc.target/arm/addr-modes-float.c (ATTR): New define.
         (POST_STORE): Pass ATTR as 2nd argument.
         (POST_LOAD): Likewise.
         (POST_STORE_VEC): Likewise.
         * gcc.target/arm/addr-modes-int.c (ATTR): New define.
         (PRE_STORE): Pass ATTR as 2nd argument.
         (POST_STORE): Likewise.
         (PRE_LOAD): Likewise.
         (POST_LOAD): Likewise.
         * gcc.target/arm/addr-modes.h (PRE_STORE): New parameter.
         (POST_STORE): Likewise.
         (POST_STORE_VEC): Likewise.
         (PRE_LOAD): Likewise.
         (POST_LOAD): Likewise.
         (POST_LOAD_VEC): Likewise.