On 11/18/2017 08:59 AM, Janne Blomqvist wrote: > On Sat, Nov 18, 2017 at 6:00 PM, Thomas Koenig <tkoe...@netcologne.de> wrote: >> Hi Janne, >> >>> This is accomplished by making the NEXTREC specifier be a 8 byte >>> integer where supported. >>> >>> I wasn't able to come up with a testcase that does not create a large >>> file that could be added to the testsuite, but here's one which >>> creates a 2 GB file: >> >> I think the patch is OK (even obvious), also without a test case, >> but maybe you could wait for a couple of days before committing to >> give others a chance to chime in. > > Thanks, committed as r254916. Since this changes the libgfortran ABI, > I wanted to get this in at the same time as the PR 44292 patch, so > people have to rebuild everything only once (yes, this is trunk, but > still). If somebody comes up with a way to test this without a huge > file, we can add such a testcase later. > >
Yes OK. We could consider setting up an automatic testing machine somewhere that not only does the usual test-suite, but also tests the unusual things like this. For example, I had a test case which died when launched with more than 32 threads for example. Not every machine or architecture could do that so I do not have a test case for it. Another example is the NIST tests which we run manually via a script. Regardless, this machine could also issue an email to the gfortran list when ever a new failure is discovered. We could do it so it does not repeat the email every day, just a report of new and a report of problem went away. Just a thought. Jerry
