On 2017.10.11 at 09:39 +0200, Jakub Jelinek wrote: > On Wed, Oct 11, 2017 at 08:24:28AM +0200, Martin Liška wrote: > > Hi. > > > > This changes error to a warning: > > warning: ‘foobar’ attribute directive ignored [-Wattributes] > > > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > What is the rationale for not warning? LLVM compatibility? > I think in some cases it would be nice to find out that I wrote a typo...
The patch does warn. But yes, not erroring out improves LLVM compatibility. Chromium uses __attribute__(no_sanitize("function")) for example. -- Markus