Re: [patch, fortran] Warn about out-of-bounds access with DO subscripts

[Thomas Schwinge]

Hi!

On Tue, 26 Sep 2017 18:51:52 +0200, Thomas Koenig <tkoe...@netcologne.de> wrote:
> > On Mon, 25 Sep 2017 18:50:49 +0200, Thomas Koenig <tkoe...@netcologne.de> 
> > wrote:
> >> Thanks for the review, committed as r253156.
> >>
> >> Now, on to some other bugs...
> > 
> > No, back to this one please.  ;-)
> 
> OK, if you insist :-)

;-)


> > And the following gets highlighted, too:
> > 
> >      FAIL: compiler driver --help=fortran option(s): "^ +-.*[^:.]$" absent 
> > from output: "  -Wdo-subscript              Warn about possibly incorrect 
> > subscripts in do loops"
> >      FAIL: compiler driver --help=warnings option(s): "^ +-.*[^:.]$" absent 
> > from output: "  -Wdo-subscript              Warn about possibly incorrect 
> > subscripts in do loops"
> 
> This I don't understand.

Hmm, don't you see that in your test logs?

> Was there anything wrong with my
> change to fortran/lang.opt?

Easy enough to fix, so as obvious, committed to trunk in r253225:

commit a7717725d0bed402378b085bcda8fa3fe337fae9
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Sep 27 08:35:05 2017 +0000

    Placate gcc.misc-tests/help.exp regarding -Wdo-subscript
    
            gcc/fortran/
            * lang.opt <Wdo-subscript>: End help text with a period.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@253225 
138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/fortran/ChangeLog | 4 ++++
 gcc/fortran/lang.opt  | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git gcc/fortran/ChangeLog gcc/fortran/ChangeLog
index d0eef84..c698014 100644
--- gcc/fortran/ChangeLog
+++ gcc/fortran/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-27  Thomas Schwinge  <tho...@codesourcery.com>
+
+       * lang.opt <Wdo-subscript>: End help text with a period.
+
 2017-09-26  Thomas Koenig  <tkoe...@gcc.gnu.org>
 
        * frontend-passes.c (do_subscript): Don't do anything
diff --git gcc/fortran/lang.opt gcc/fortran/lang.opt
index 37ed4a3..88f6af5 100644
--- gcc/fortran/lang.opt
+++ gcc/fortran/lang.opt
@@ -239,7 +239,7 @@ Warn about most implicit conversions.
 
 Wdo-subscript
 Fortran Var(warn_do_subscript) Warning LangEnabledBy(Fortran,Wextra)
-Warn about possibly incorrect subscripts in do loops
+Warn about possibly incorrect subscripts in do loops.
 
 Wextra
 Fortran Warning


Grüße
 Thomas