On Sat, Jul 29, 2017 at 8:48 PM, Andrew Pinski <apin...@cavium.com> wrote: > Hi, > When I was playing around where lowering of bit-field accesses go in > the pass order, I found that DOM had the same issue as PRE had when it > came to comparing BIT_INSERT_EXPR for equality. The same exact > testcase was showing the wrong code; gcc.dg/tree-ssa/20040324-1.c. > > This fixes DOM the same way as I had fixed PRE, by special casing > BIT_INSERT_EXPR due to the implicit operand. > > OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions.
Watch excess vertical space: + return false; + + if (operand_equal_p (expr0->ops.ternary.opnd0, Ok with that fixed. Thanks, Richard. > Thanks, > Andrew Pinski > > ChangeLog: > * tree-ssa-scopedtables.c (hashable_expr_equal_p): Check > BIT_INSERT_EXPR's operand 1 > to see if the types precision matches.