On Wed, Jul 19, 2017 at 10:51:33AM -0400, David Malcolm wrote:
> The changes to diagnostic-core.h and diagnostic.c are OK.
Thanks.
> > Also,
> > PEDWARN_FOR_ASSIGNMENT didn't work with the addition of printing TYPE
> > and
> > RHSTYPE so I just decided to unroll the macro instead of making it
> > even more
> > ugly.
> > This patch is long but it's mainly because of the testsuite fallout.
>
> The comment by PEDWARN_FOR_ASSIGNMENT says:
>
>
> /* This macro is used to emit diagnostics to ensure that all format
> strings are complete sentences, visible to gettext and checked
> at
> compile time. */
>
> I wonder if it's possible to convert it to an inline function to get
> the same test coverage, without unrolling the macro?
Yeah, I tried, but the resulting inline function would have to have 12
parameters if I count well and that didn't seem like a win. Perhaps
splitting convert_for_assignment would make sense, but likely not as
part of this patch.
Marek
