On 07/11/2017 07:45 PM, David Malcolm wrote: > On Mon, 2017-07-10 at 11:36 +0200, Martin Liška wrote: >> Hi. >> >> This adds missing quotes to various error messages related to >> AddressSanitizer. >> Patch can bootstrap on ppc64le-redhat-linux and survives regression >> tests. >> >> Ready to be installed? > > LGTM, with my "diagnostic messages" maintainer hat on.
Patch has been just installed. > > Grepping for "-f" within opts.c shows a few other diagnostics there > that could use quotes, but that's not a reason not to go ahead with > this patch. Yep, I'm testing another patch. Martin > > Thanks > Dave > >> Martin >> >> gcc/ChangeLog: >> >> 2017-07-04 Martin Liska <mli...@suse.cz> >> >> * opts.c (finish_options): Add quotes to error messages. >> (parse_sanitizer_options): Likewise. >> >> gcc/testsuite/ChangeLog: >> >> 2017-07-04 Martin Liska <mli...@suse.cz> >> >> * c-c++-common/ubsan/sanitize-all-1.c: Update scanned pattern. >> * c-c++-common/ubsan/sanitize-recover-1.c:Likewise. >> * c-c++-common/ubsan/sanitize-recover-2.c:Likewise. >> * c-c++-common/ubsan/sanitize-recover-5.c:Likewise. >> * c-c++-common/ubsan/sanitize-recover-7.c:Likewise. >> * c-c++-common/ubsan/sanitize-recover-8.c:Likewise. >> * c-c++-common/ubsan/sanitize-recover-9.c:Likewise. >> --- >> gcc/opts.c | 18 +++++++++ >> --------- >> gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c | 2 +- >> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c | 2 +- >> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c | 2 +- >> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c | 2 +- >> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c | 2 +- >> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c | 2 +- >> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c | 2 +- >> 8 files changed, 16 insertions(+), 16 deletions(-) >> >>
