Ok. I fixed the enum formatting and the enums remain internal. -Julia
-----Original Message----- From: Andrew Senkevich [mailto:andrew.n.senkev...@gmail.com] Sent: Tuesday, January 10, 2017 5:48 PM To: Uros Bizjak <ubiz...@gmail.com> Cc: Koval, Julia <julia.ko...@intel.com>; GCC Patches <gcc-patches@gcc.gnu.org>; vaalfr...@gmail.com Subject: Re: [PATCH] Enable SGX intrinsics On Fri, Dec 30, 2016 at 03:37:14PM +0100, Uros Bizjak wrote: >> As suggested in [1], you should write multi-line enums like: >> >> enum foo >> { >> a = ... >> b = ... >> } > > Sure. Plus it depends on if users of the APIs should just write the operands > on their own as numbers, or as __SGX_E*, or as E*. > In the first case the patch sans formatting is reasonable, in the second case > the enums should be moved to file scope, in the last case we have to live > with the namespace pollution. > The pdf you've referenced in the thread doesn't list the _encls_u32 and > _enclu_u32 intrinsics, so I think it depends on what ICC does (if it has been > shipped with such a support already, or on coordination with ICC if not). Jakub, it is in accordance with ICC. So the first case will be used. -- WBR, Andrew
0001-Enable-SGX.PATCH
Description: 0001-Enable-SGX.PATCH
