On Fri, Dec 30, 2016 at 03:37:14PM +0100, Uros Bizjak wrote: > As suggested in [1], you should write multi-line enums like: > > enum foo > { > a = ... > b = ... > }
Sure. Plus it depends on if users of the APIs should just write the operands on their own as numbers, or as __SGX_E*, or as E*. In the first case the patch sans formatting is reasonable, in the second case the enums should be moved to file scope, in the last case we have to live with the namespace pollution. The pdf you've referenced in the thread doesn't list the _encls_u32 and _enclu_u32 intrinsics, so I think it depends on what ICC does (if it has been shipped with such a support already, or on coordination with ICC if not). Jakub