On Wed, Dec 21, 2016 at 03:13:29PM -0700, Jeff Law wrote:
> > > Also in pass_post_ipa_warn::execute, the BITMAP_FREE call is technically
> > > in
> > > a correct position, but it might be more maintainable long term if the
> > > allocation/deallocation occur at the same nesting level.
> >
> > The only case where it makes a difference is where the bitmap is NULL and
> > there is nothing to free (and that is the common case).
> Yes, I know. It's more a style issue -- having the allocation/deallocation
> at the same scoping level is simply easier for humans to process and thus
> makes it much less likely for someone to muck it up later (particularly if
> that routine grows).
But in this case the allocation is just in a different routine, and is only
conditional, and the deallocation is conditional as well.
Jakub
