On Thu, Dec 08, 2016 at 03:30:59PM +0000, Wilco Dijkstra wrote:
> This patch fixes an issue in aarch64_classify_address.  TImode and TFmode
> can either use a 64-bit LDP/STP or 128-bit LDR/STR.  The addressing mode
> must be carefully modelled as the intersection of both.  This is done for
> the immediate offsets, however load_store_pair_p must be set as well to
> avoid LDP with a PC-relative address if aarch64_pcrelative_literal_loads
> is true.
> 
> Bootstrap passes with aarch64_pcrelative_literal_loads=true.

I presume you also made a testsuite run?

You should be able to do something like:

  make check RUNTESTFLAGS="--target_board=unix/-mpc-relative-literal-loads"

To run the entire testsuite with -mpc-relative-literal-loads.

Thanks for the prompt fix.

This is OK assuming you've run the testsuite and it has come back clean.

Thanks,
James

> 
> ChangeLog:
> 2015-12-08  Wilco Dijkstra  <wdijk...@arm.com>
> 
>       PR target/78733
>       * config/aarch64/aarch64.c (aarch64_classify_address):
>       Set load_store_pair_p for TImode and TFmode.
> 
>     /testsuite
>       * gcc.target/aarch64/pr78733.c: New test.

Reply via email to