On 2 December 2016 at 17:35, Thomas Preudhomme <thomas.preudho...@foss.arm.com> wrote: > Hi, > > The logic to make -mthumb optional for Thumb-only targets was designed to > only apply when no mode is specified either at compile time or when the > toolchain was configured (using --with-mode). The dg-skip-if in the > testcases optional_thumb-1 and optional_thumb-2 catch the former case but > not the latter. Unfortunately there is no dejagnu procedure to check the > presence of an option in the configure line used for the compiler. This > patch marks the two tests as XFAIL since that will at least allow to catch a > change from PASS to XFAIL, thus making the test still useful. It also fixes > a codestyle issue in the target triplet of the dg-skip-if directives of all > the optional_thumb-* testcases. >
So, this makes the test XPASS when no --with-mode or --with-mode=thumb is used. Isn't it possible to add an dejagnu effective target to detect this configure option? I guess you looked at that but the effort is not worth it? Christophe > ChangeLog entry is as follows: > > *** gcc/testsuite/ChangeLog *** > > 2016-12-01 Thomas Preud'homme <thomas.preudho...@arm.com> > > * gcc.target/arm/optional_thumb-3.c: Fix codestyle issue in target > triplet of dg-skip-if. > * gcc.target/arm/optional_thumb-1.c: Likewise and add xfail. > * gcc.target/arm/optional_thumb-2.c: Likewise. > > Is this ok for stage3? > > Best regards, > > Thomas
