On 20 November 2016 at 18:27, Mike Stump <mikest...@comcast.net> wrote:
> On Nov 19, 2016, at 1:59 PM, Andrew Burgess <andrew.burg...@embecosm.com>
> wrote:
>>> So, your new test fails on arm* targets:
>>
>> After a little digging I think the problem might be that
>> -freorder-blocks-and-partition is not supported on arm.
>>
>> This should be detected as the new tests include:
>>
>> /* { dg-require-effective-target freorder } */
>>
>> however this test passed on arm as -freorder-blocks-and-partition does
>> not issue any warning unless -fprofile-use is also passed.
>>
>> The patch below extends check_effective_target_freorder to check using
>> -fprofile-use. With this change in place the tests are skipped on
>> arm.
>
>> All feedback welcome,
>
> Seems reasonable, unless a -freorder-blocks-and-partition/-fprofile-use
> person thinks this is the wrong solution.
>
Hi,
As promised, I tested this patch: it makes
gcc.dg/tree-prof/section-attr-[123].c
unsupported on arm*, and thus they are not failing anymore :-)
However, it also makes other tests unsupported, while they used to pass:
gcc.dg/pr33648.c
gcc.dg/pr46685.c
gcc.dg/tree-prof/20041218-1.c
gcc.dg/tree-prof/bb-reorg.c
gcc.dg/tree-prof/cold_partition_label.c
gcc.dg/tree-prof/comp-goto-1.c
gcc.dg/tree-prof/pr34999.c
gcc.dg/tree-prof/pr45354.c
gcc.dg/tree-prof/pr50907.c
gcc.dg/tree-prof/pr52027.c
gcc.dg/tree-prof/va-arg-pack-1.c
and failures are now unsupported:
gcc.dg/tree-prof/cold_partition_label.c
gcc.dg/tree-prof/section-attr-1.c
gcc.dg/tree-prof/section-attr-2.c
gcc.dg/tree-prof/section-attr-3.c
So, maybe this patch is too strong?
Christophe
