On 11/16/2016 03:12 PM, Andrew Burgess wrote:
* Mike Stump <mikest...@comcast.net> [2016-11-16 12:59:53 -0800]:
On Nov 16, 2016, at 12:09 PM, Andrew Burgess <andrew.burg...@embecosm.com>
wrote:
My only remaining concern is the new tests, I've tried to restrict
them to targets that I suspect they'll pass on with:
/* { dg-final-use { scan-assembler "\.section\[\t
\]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold\.0" { target
*-*-linux* *-*-gnu* } } } */
but I'm still nervous that I'm going to introduce test failures. Is
there any advice / guidance I should follow before I commit, or are
folk pretty relaxed so long as I've made a reasonable effort?
So, if you are worried about the way the line is constructed, I usually test it
by misspelling the *-*-linux* *-*-gnu* part as *-*-linNOTux* *-*-gnNOTu* and
see if the test then doesn't run on your machine. If it doesn't then you can
be pretty confident that only machines that match the target triplet can be
impacted. I usually do this type of testing by running the test case in
isolation (not the full tests suite). Anyway, do the best you can, and don't
worry about t it too much, learn from the experience, even if it goes wrong in
some way. If it did go wrong, just be responsive (don't check it in just
before a 6 week vacation) about fixing it, if you can.
Thanks for the feedback.
Change committed as revision 242519. If anyone sees any issues just
let me know.
Thanks. And thanks for seeing this through... I know it's a pain sometimes.
jeff
