On 2016.10.12 at 12:54 +0200, Jakub Jelinek wrote: > On Wed, Oct 12, 2016 at 12:36:29PM +0200, Markus Trippelsdorf wrote: > > Here are some examples: > > > > /* Don't break */ > > /* drop through */ //very popular > > /* fall though */ > > /* pass through... */ > > /* break intentionally omitted */ > > /* fallthough */ > > /* Don't break, this is a failed frame! */ > > /* leave break out intentionly */ > > /* else: Fall trough */ > > /* passthrough */ > > /* NOBREAK */ > > /* follow thru */ > > /* go through here */ > > It would be nice to see all those 136 comments, perhaps sort | uniq -c > merged together. > Letting people fix fall though or fallthough or Fall trough misspellings > is a good thing. And for the others, I think the comment adjustment won't > take more than a few seconds each, compared to having to analyze the 900+ > cases.
I'm more concerned about the first impression that people will get from this warning. If the fist couple of samples they will look at are clearly bogus (as with the example comments above) they will very quickly disable the warning. And if a small one digit percentage of all potential issues falls through the cracks with -Wimplicit-fallthrough=1 , so be it. -- Markus
