-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/31/11 15:41, Bernd Schmidt wrote: > On 08/29/11 18:02, Jeff Law wrote: >> On 08/26/11 08:47, Bernd Schmidt wrote: >>> In rest_of_reorder_blocks, we avoid reordering if >>> !optimize_function_for_speed_p. However, we still call >>> insert_section_bounary_note, which can cause problems because >>> now, if we have a sequence of HOT-COLD-HOT blocks, the second set >>> of HOT blocks will end up in the cold section. This causes >>> assembler failures when using exception handling (subtracting >>> labels from different sections). >> >>> Unfortunately, the only way I have of reproducing it is to apply >>> a 67-patch quilt tree backporting the preliminary >>> shrink-wrapping patches to gcc-4.6; then we get >> >>> FAIL: g++.dg/tree-prof/partition2.C compilation, -Os >>> -fprofile-use >> >>> However, the problem is reasonably obvious. Bootstrapped and >>> currently testing in the aforementioned 4.6 tree. Ok for trunk >>> after testing there? >> OK after testing. > > Thanks. Committed, but on second thought something like the below is > probably cleaner; it also avoids partitioning if we're not going to > reorder blocks. Tested along with the shrink-wrapping patches on > i686-linux and mips64-elf. That looks OK too. Jeff
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOXw67AAoJEBRtltQi2kC78icH/jJAqu9jwiNIRZUgtbCu5f9i gD7S0+BNY/mIooZoQXl6trD9K5Xuzb7Y78DAWR+Zlz10SewyD0+EMWjm+w+z00gb UKLZSH/Qx0sgKXKWw4k72yzPVKCA62D6XskCD7gNA1hbxTp9V+ino31FE0RxaFLM /MpcJqJaKJ72s5kHJq3MRlldY4rcfVWyFHxkTaGgMml3C61TO53o6ZIsC3xiFzUp 2hs/SUq4rJRMV5DMDZiupkcJ7yUpEGLFa5xMQnd8JCKYk4rHkDdP2NGgko5/3szW J7xvjg4EFHkC0befzKyAVWF4eGyUmWUfog/+npvfsSM3rjS1mv126oABAnkwQsU= =CHim -----END PGP SIGNATURE-----
