On Thu, Jun 09, 2016 at 07:01:47PM +0200, Paolo Carlini wrote: > Now the first comment I have about this, about which I'd like to have some > feedback, is that the gcc_unreachable () at the end of > build_simple_base_path without a return seems a bit weird to me, because the > function is *supposed to return a tree*, not void. I guess some front-ends > would even warn on this?!? Anyway, if we change: > > > /* */ > > gcc_unreachable (); > }
I'll just comment on this. gcc_unreachable () is a noreturn function, so this is perfectly fine IMHO. Jakub