On 27/05/16 14:24, James Greenhalgh wrote:
On Tue, May 24, 2016 at 09:23:48AM +0100, Jiong Wang wrote:These intrinsics were implemented before the instruction pattern "aarch64_rsqrte<mode>" added, that these intrinsics were implemented through inline assembly. This mirgrate the implementation to builtin. gcc/ 2016-05-23 Jiong Wang <jiong.w...@arm.com> * config/aarch64/aarch64-builtins.def (rsqrte): New builtins for modes VALLF. * config/aarch64/aarch64-simd.md (aarch64_rsqrte_<mode>2): Rename to "aarch64_rsqrte<mode>". * config/aarch64/aarch64.c (get_rsqrte_type): Update gen* name. * config/aarch64/arm_neon.h (vrsqrts_f32): Remove inline assembly. Use builtin. (vrsqrted_f64): Likewise. (vrsqrte_f32): Likewise. (vrsqrteq_f32): Likewise. (vrsqrteq_f64): Likewise.This ChangeLog is not in the correct form. It looks like you are missing vrsqrte_f64, could you please add that?
vrsqrte_f64 wasn't cleaned up in this patch because it's input type is float64x1 which caused trouble during fitting it into aarch64 builtin infrastructure cleanly.
I might missed some thing, will double check this.
