On Wed, Apr 20, 2016 at 7:54 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Wed, Apr 20, 2016 at 07:45:44AM -0700, H.J. Lu wrote: >> On Wed, Apr 20, 2016 at 12:02 AM, Uros Bizjak <ubiz...@gmail.com> wrote: >> >> >> >> That is why I submitted my patches. Since -m32 passes -march=x86-64 >> >> to cc1 on x86-64, we shouldn't pass -march=i486 to cc1. It is >> >> undesirable >> >> especially when --with-arch= is used. I noticed the issue when 32-bit >> >> libatomic/libgomp/libitm weren't optimized with -march=haswell when GCC >> >> was configured with --with-arch=haswell >> > >> > OK then. IMO, following comment is more informative: >> > >> > # x86_64 compiler passes -march=x86_64 by default when building 32bit >> > target libraries. >> > >> >>>>>>>> + # Since 64-bit arch > i486, we can use the same -march= to >> >>>>>>>> build >> >>>>>>>> + # both 32-bit and 64-bit target libraries. >> > >> > OK with the above change. >> > >> >> This is the patch I checked in. I also updated patches for libgomp: >> >> https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01079.html >> >> and libitm: >> >> https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01080.html > > This is wrong, see my other comment on the libgomp patch. >
See my reply to your reply on the libgomp patch. -- H.J.
