On 04/04/2016 11:59 AM, Martin Sebor wrote:
My recent change to check_GNU_style.sh (commit 1bbf98) introduces false positives for declarations of functions with a pointer return type. For example, in the following, the asterisk in the "void *" return type is incorrectly diagnosed as a trailing operator:-void -foo (void); +void * +foo (int); The patch below avoids those false positive for file-scope and namespace-scope functions. Martin index fbf6cb2..a7478f8 100755 --- a/contrib/check_GNU_style.sh +++ b/contrib/check_GNU_style.sh @@ -240,6 +240,7 @@ g 'There should be no space before closing parenthesis.' \ g 'Braces should be on a separate line.' \ '(\)|else)[[:blank:]]*{' -# Does this apply to definition of aggregate objects? -g 'Trailing operator.' \ +# Does this apply to definitions of aggregate objects? +ag 'Trailing operator.' \ + '^[1-9][0-9]*:\+[[:space:]]' \ '(([^a-zA-Z_]\*)|([-%<=&|^?])|([^*]/)|([^:][+]))$'
OK. jeff
