Re: [PATCH, testsuite/ARM] Skip pr70496.c for cortex-m devices

[Kyrill Tkachov]

Hi Thomas,

On 06/04/16 12:03, Thomas Preudhomme wrote:

Hi,

Testcase in gcc.target/arm/pr70496.c uses an .arm directive so assumes the
target has an ARM execution state. This patch adds a dg-skip-if directive to
skip that test on Cortex-M targets since they don't have such an execution
state.

ChangeLog entry is as follows:


*** gcc/testsuite/ChangeLog ***

2016-04-06  Thomas Preud'homme  <thomas.preudho...@arm.com>

         PR testsuite/70553
         * gcc.target/arm/pr70496.c: Skip for ARM Cortex-M targets.


diff --git a/gcc/testsuite/gcc.target/arm/pr70496.c
b/gcc/testsuite/gcc.target/arm/pr70496.c
index
89957e2c7a75cb89153b3e3fc34d8051b6a997d1..548a8243059ddaec63ed897dc67f4751d806a065
100644
--- a/gcc/testsuite/gcc.target/arm/pr70496.c
+++ b/gcc/testsuite/gcc.target/arm/pr70496.c
@@ -1,6 +1,7 @@
  /* { dg-do assemble } */
  /* { dg-options "-mthumb -O2" } */
  /* { dg-require-effective-target arm_thumb2_ok } */
+/* { dg-skip-if "does not have ARM state" { arm_cortex_m } } */

Would it be better to just require the arm_arm_ok effective target?
That should try to compile a test with -marm added to the command,
which should fail for Cortex-M targets.

Thanks,
Kyrill

  int i;
  void




Is this ok for trunk?

Best regards,

Thomas