On 11-08-17 22:09 , Gabriel Charette wrote:
Can you approve version 1 instead?!
Sure, that variant is fine as well. Whichever version better suits your next patch.
The documentation is on the variable in the C file directly as I've noticed this is what is done most of the time... I put it at that line in the file because this is where the references from pph-streamer.c are (unless it's different for variables then it is for functions??)
I tend to stick globals at the start of the header to make them more visible. Cutting and pasting the same documentation on both places is fine.
Thanks. Diego.
