Thinking more about this on my way back... I will only need includes directly included by the current pph, not the full include tree as I added in version 2 of this patch thinking I would need it for the line_table...
Can you approve version 1 instead?! > http://codereview.appspot.com/4904050/diff/3001/gcc/cp/pph-streamer.h#newcode210 > gcc/cp/pph-streamer.h:210: extern VEC(pph_stream_ptr, heap) > *pph_read_images; >> >> 209 >> 210 extern VEC(pph_stream_ptr, heap) *pph_read_images; > > Move earlier in the file and add documentation. The documentation is on the variable in the C file directly as I've noticed this is what is done most of the time... I put it at that line in the file because this is where the references from pph-streamer.c are (unless it's different for variables then it is for functions??) Cheers, Gab
