On Wed, Mar 02, 2016 at 01:59:04PM +0100, Uros Bizjak wrote: > > --- gcc/testsuite/gcc.target/i386/pr70028.c.jj 2016-03-01 > > 20:11:09.142593365 +0100 > > +++ gcc/testsuite/gcc.target/i386/pr70028.c 2016-03-01 > > 20:13:52.122377175 +0100 > > @@ -0,0 +1,19 @@ > > +/* PR target/70028 */ > > +/* { dg-do assemble { target int128 } } */ > > +/* { dg-require-effective-target avx512bw } */ > > Just a nit ... can above two lines be swapped, so we have: > > /* { dg-do assemble { target avx512bw } } */ > /* { dg-require-effective-target int128 } */
Ok, will do. > This way, we can easily grep through the testcases for required ISAs. > > Otherwise, the patch looks good to be, but let's wait for Kirill for > the final say. I've missed Kirill said: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70028#c4 So I'll commit with the above change. Jakub