On Tue, Mar 01, 2016 at 09:31:26AM -0700, Jeff Law wrote:
> On 02/24/2016 09:31 AM, Marek Polacek wrote:
> >The following is another issue with macros from system headers.  In this case
> >bool is defined in a system header to expand to _Bool and the "is promoted 
> >to"
> >warning didn't trigger because of that.  The fix is to use the expanded 
> >location.
> >
> >Bootstrapped/regtested on x86_64-linux, ok for trunk?
> >
> >2016-02-24  Marek Polacek  <pola...@redhat.com>
> >
> >     PR c/67854
> >     * gimplify.c (gimplify_va_arg_expr): Use expanded location for the
> >     "is promoted to" warning.
> >
> >     * gcc.dg/pr67854.c: New test.
> This isn't a regression, so I put it in my gcc-7 bucket.  Is this something
> we really need to address in gcc-6?
 
Well, gcc4.7 warned, the warning disappeared in gcc4.8, so I think this is
a regression.  I'm fine with deferring to 7 though.

> FWIW, I think the patch is technically fine.

Thanks,

        Marek

Reply via email to