ping!
2016-02-05 19:19 GMT+01:00 Janus Weil <ja...@gcc.gnu.org>: > Hi all, > > I have slightly updated the patch now to avoid string-breaking issues > (even if it may not be a problem at all, as mentioned by Jospeh). Also > I removed the questionable part in intrinsic.c that I was not sure > about. > > This version of the patch should not be too far from obvious now. Ok for > trunk? > > Cheers, > Janus > > > > 2016-02-03 23:27 GMT+01:00 Joseph Myers <jos...@codesourcery.com>: >> On Wed, 3 Feb 2016, Manfred Schwarb wrote: >> >>> There are 2 things with translation, and there is a third issue: >>> - As you noticed, breaking things differently means translation has to be >>> done again. >>> - Normally, each string is translated independently, and depending on the >>> language there may be lack of context (e.g. adjectives get different >>> suffixes >>> depending on the noun). >> >> I believe gettext works fine with (compile-time) string constant >> concatenation - that is, extracts the whole concatenated string for >> translation, so these are non-issues. What doesn't work includes: >> >> * Runtime concatenation of strings or otherwise putting English fragments >> together at runtime. >> >> * String constant concatenation where one of the concatenated pieces comes >> from a macro expansion. >> >> * The argument for translation being a conditional expression: >> >> error (cond ? "message 1" : "message 2"); >> >> (in this case, only one of the messages may be extracted for translation, >> so you need to mark both of them up with appropriate macros such as G_). >> >> -- >> Joseph S. Myers >> jos...@codesourcery.com