> So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc, > tilegx, tilepro or xtensa. > :-( That’s one of the problems by having each port copy and paste swaths of > :code from other ports to express the same thing instead of ports sharing > :just one copy of code. My port is also broken in the same way > :(currently).
Yes, fixing a compiler bug by changing the ABI is a no-no, and the argument of the compatibility with LLVM has IMO little merit since it's a GCC extension. > I’m curious why the caller of the hook can’t grab the main variant, if it > wants. If it did this, then all the ports are fixed wrt this issue. Or just fix PRE wrt the alignment discrepancy, which looks a lot safer to me. It's not because this works on x86 that this is necessarily correct for all the other architectures, especially the strict-alignment architectures. -- Eric Botcazou
