On Wed, Jan 13, 2016 at 06:39:30PM +0100, Martin Jambor wrote:
> @@ -726,14 +730,14 @@ struct GTY((tag("GSS_OMP_CONTINUE")))
> tree control_use;
> };
>
> -/* GIMPLE_OMP_SINGLE, GIMPLE_OMP_TEAMS, GIMPLE_OMP_ORDERED */
> +/* GIMPLE_OMP_SINGLE, GIMPLE_OMP_ORDERED */
I think in this patch GIMPLE_OMP_TEAMS uses GSS_OMP_SINGLE_LAYOUT,
so the comment change is wrong.
> @@ -16489,7 +17075,682 @@ lower_omp (gimple_seq *body, omp_context *ctx)
> fold_stmt (&gsi);
> input_location = saved_location;
> }
> -
Can you please keep the form feed char after the set of grid_* functions?
> +static void
> +grid_gridify_all_targets (gimple_seq *body_p)
> +{
> + struct walk_stmt_info wi;
> + memset (&wi, 0, sizeof (wi));
> + walk_gimple_seq_mod (body_p, grid_gridify_all_targets_stmt, NULL, &wi);
> +}
> +
Here?
> +
> /* Main entry point. */
>
> static unsigned int
> --- a/gcc/tree.h
> +++ b/gcc/tree.h
> @@ -1636,6 +1636,17 @@ extern void protected_set_expr_location (tree,
> location_t);
> #define OMP_CLAUSE_TILE_LIST(NODE) \
> OMP_CLAUSE_OPERAND (OMP_CLAUSE_SUBCODE_CHECK (NODE, OMP_CLAUSE_TILE), 0)
>
> +#define OMP_CLAUSE_GRIDDIM_DIMENSION(NODE) \
> + (OMP_CLAUSE_SUBCODE_CHECK (NODE, OMP_CLAUSE__GRIDDIM_)\
> + ->omp_clause.subcode.dimension)
> +#define OMP_CLAUSE_SET_GRIDDIM_DIMENSION(NODE, DIMENSION) \
> + (OMP_CLAUSE_SUBCODE_CHECK (NODE, OMP_CLAUSE__GRIDDIM_)\
> + ->omp_clause.subcode.dimension = (DIMENSION))
Why do you need a separate SET? OMP_CLAUSE_GRIDDIM_DIMENSION (node) =
dimension;
should work just fine.
Ok with these changes.
Jakub
