> Here is my amended patch. I have fixed the stylistic issues in both
> s-osinte-kfreebsd-gnu.ads and in the original place,
> s-osinte-freebsd.ads. I hope the changelog entry is more correct, too.
Better but not quite the standard style yet. I believe there's a doc in gnu.org
explaining the proper format for ChangeLogs. I'd suggest you familiarize
yourself with this document.
> 2011-08-05 Ludovic Brenta <ludo...@ludovic-brenta.org>
>
> PR ada/49944
> * s-osinte-freebsd.ads:
> - update copyright years.
> - minor reformatting.
We don't use "-" in changelog in general, so would be more something like:
* s-osinte-freebsd.ads: Update copyright years. Minor reformatting.
(Stack_Base_Available): Correct comments.
Also we don't put a newline just after the file name.
> * gcc-interface/Makefile.in (kfreebsd%):
> use s-taprop-posix.ad[bs] instead of s-taprop-linux.ad[bs].
> use s-tasinf.ad[bs] instead of s-tasinf-linux.ad[bs].
> * s-osinte-kfreebsd-gnu.ads
> (Time_Slice_Supported): copy from s-osinte-freebsd.ads.
> (nanosleep): ditto.
> (clock_id_t, clock_gettime): ditto.
> (Stack_Base_Available): ditto.
> (Get_Page_Size): ditto.
> (mprotect): ditto.
> (pthread_mutexattr_setprotocol): ditto.
> (pthread_mutexattr_getprotocol): ditto.
> (pthread_mutexattr_setprioceiling): ditto.
> (pthread_mutexattr_getprioceiling): ditto.
> (pthread_attr_setscope): ditto.
> (pthread_attr_getscope): ditto.
> (pthread_attr_setinheritsched): ditto.
> (pthread_attr_getinheritsched): ditto.
The indentation is wrong above, should be one TAB character everywhere.
You can also list all functions at once, and after a semicolon, usually
you should start with an upper case:
* s-osinte-kfreebsd-gnu.ads (Time_Slice_Supported, nanosleep,
clock_id_t, clock_gettime, Stack_Base_Available, Get_Page_Size,
mprotect, pthread_mutexattr_setprotocol, pthread_mutexattr_getprotocol,
pthread_mutexattr_setprioceiling, pthread_mutexattr_getprioceiling,
pthread_attr_setscope, pthread_attr_getscope,
pthread_attr_setinheritsched, pthread_attr_getinheritsched,
Time_Slice_Supported): Copy from s-osinte-freebsd.ads.
> --- This is the GNU/kFreeBSD (GNU/LinuxThreads) version of this package
> +-- This is the GNU/kFreeBSD PTHREADS version of this package
Not sure why PTHREADS is upper cased here, any specific reason? If not,
I'd lower case it. Actually I'd probably replace it by:
-- This is the GNU/kFreeBSD (POSIX Threads) version of this package
unless "PTHREADS" has a special meaning on kFreeBSD.
OK with the above changes.
Arno
