> Pursuant to Arno's comments on PR ada/49444, here is another patch that
> allows GCC to compile with Ada support on Debian GNU/kFreeBSD.
> 
> 2011-08-04  Ludovic Brenta <ludo...@ludovic-brenta.org>
> 
>     * gcc/ada/gcc-interface/Makefile.in (kfreebsd%):
>       - use s-taprop-posix.ad[bs] instead of s-taprop-linux.ad[bs]
>       - use use s-tasinf.ad[bs] instead of s-tasinf-linux.ad[bs].
>     * s-osinte-kfreebsd-gnu.ads: allow the above by bringing the
>       interface closer to s-osinte-freebsd.ads.

The above ChangeLog isn't quite in the proper format.
Also see below for a few stylistic issues to fix.

Once fixed, the patch is OK to commit, thanks.

Arno

> --- a/src/gcc/ada/s-osinte-kfreebsd-gnu.ads
> +++ b/src/gcc/ada/s-osinte-kfreebsd-gnu.ads
> @@ -200,8 +200,24 @@
>     -- Time --
>     ----------
>  
> +   Time_Slice_Supported : constant Boolean := True;
> +   --  Indicates whether time slicing is supported (i.e SCHED_RR is
> supported)
> +
>     type timespec is private;
>  
> +   function nanosleep (rqtp, rmtp : access timespec)  return int;

remove extra blank here                                ^

> @@ -286,9 +316,32 @@
>     Alternate_Stack_Size : constant := 0;
>     --  No alternate signal stack is used on this platform
>  
> +   Stack_Base_Available : constant Boolean := False;
> +   --  Indicates whether the stack base is available on this target. This
> +   --  allows us to share s-osinte.adb between all the FSU run time. Note 
> that
> +   --  this value can only be true if pthread_t has a complete definition 
> that
> +   --  corresponds exactly to the C header files.

The above comment is wrong/obsolete. Replace it simply by:

   --  Indicates whether the stack base is available on this target

Arno

Reply via email to