Re: [PATCH 4b/4] [ARM] PR63870 Remove error for invalid lane numbers

[Kyrill Tkachov]

On 11/11/15 12:08, Charles Baylis wrote:

On 11 November 2015 at 11:22, Kyrill Tkachov <kyrylo.tkac...@arm.com> wrote:

Hi Charles,

On 08/11/15 00:26, charles.bay...@linaro.org wrote:

From: Charles Baylis <charles.bay...@linaro.org>

<DATE>  Charles Baylis  <charles.bay...@linaro.org>

         * config/arm/neon.md (neon_vld1_lane<mode>): Remove error for
invalid
         lane number.
         (neon_vst1_lane<mode>): Likewise.
         (neon_vld2_lane<mode>): Likewise.
         (neon_vst2_lane<mode>): Likewise.
         (neon_vld3_lane<mode>): Likewise.
         (neon_vst3_lane<mode>): Likewise.
         (neon_vld4_lane<mode>): Likewise.
         (neon_vst4_lane<mode>): Likewise.

In this pattern the 'max' variable is now unused, causing a bootstrap
-Werror failure on arm.
I'll test a patch to fix it unless you beat me to it...

Thanks for catching this.

I have a patch, and have started a bootstrap. Unless you have
objections, I'll apply as obvious once the bootstrap is complete later
this afternoon.

Yes, that's the exact patch I'm testing as well.
I'll let you finish the bootstrap and commit it.

Thanks,
Kyrill

     gcc/ChangeLog:

     2015-11-11  Charles Baylis  <charles.bay...@linaro.org>

         * config/arm/neon.md: (neon_vld2_lane<mode>): Remove unused max
         variable.
         (neon_vst2_lane<mode>): Likewise.
         (neon_vld3_lane<mode>): Likewise.
         (neon_vst3_lane<mode>): Likewise.
         (neon_vld4_lane<mode>): Likewise.
         (neon_vst4_lane<mode>): Likewise.