This patch updates libgo from the Go 1.5 release to the Go 1.5.1
release. It's fairly small. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 229616)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-4b6b496579225cdd897130f6d6fd18ecb100bf99
+17cc10f7fb07e3f37448feaeb416b52618ae8bbb
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: libgo/MERGE
===================================================================
--- libgo/MERGE (revision 229616)
+++ libgo/MERGE (working copy)
@@ -1,4 +1,4 @@
-bb03defe933c89fee44be675d7aa0fbd893ced30
+f2e4c8b5fb3660d793b2c545ef207153db0a34b1
The first line of this file holds the git revision number of the
last merge done from the master library sources.
Index: libgo/VERSION
===================================================================
--- libgo/VERSION (revision 229616)
+++ libgo/VERSION (working copy)
@@ -1 +1 @@
-go1.5
\ No newline at end of file
+go1.5.1
\ No newline at end of file
Index: libgo/go/cmd/go/alldocs.go
===================================================================
--- libgo/go/cmd/go/alldocs.go (revision 229616)
+++ libgo/go/cmd/go/alldocs.go (working copy)
@@ -81,7 +81,6 @@ and test commands:
-a
force rebuilding of packages that are already up-to-date.
- In Go releases, does not apply to the standard library.
-n
print the commands but do not run them.
-p n
Index: libgo/go/cmd/go/build.go
===================================================================
--- libgo/go/cmd/go/build.go (revision 229616)
+++ libgo/go/cmd/go/build.go (working copy)
@@ -60,7 +60,6 @@ and test commands:
-a
force rebuilding of packages that are already up-to-date.
- In Go releases, does not apply to the standard library.
-n
print the commands but do not run them.
-p n
Index: libgo/go/cmd/go/pkg.go
===================================================================
--- libgo/go/cmd/go/pkg.go (revision 229616)
+++ libgo/go/cmd/go/pkg.go (working copy)
@@ -372,7 +372,8 @@ func loadImport(path, srcDir string, par
if gobin != "" {
bp.BinDir = gobin
}
- if err == nil && !isLocal && bp.ImportComment != "" && bp.ImportComment
!= path && (!go15VendorExperiment || !strings.Contains(path, "/vendor/")) {
+ if err == nil && !isLocal && bp.ImportComment != "" && bp.ImportComment
!= path &&
+ (!go15VendorExperiment || (!strings.Contains(path, "/vendor/")
&& !strings.HasPrefix(path, "vendor/"))) {
err = fmt.Errorf("code in directory %s expects import %q",
bp.Dir, bp.ImportComment)
}
p.load(stk, bp, err)
Index: libgo/go/fmt/scan.go
===================================================================
--- libgo/go/fmt/scan.go (revision 229616)
+++ libgo/go/fmt/scan.go (working copy)
@@ -83,6 +83,8 @@ func Scanln(a ...interface{}) (n int, er
// the format. It returns the number of items successfully scanned.
// If that is less than the number of arguments, err will report why.
// Newlines in the input must match newlines in the format.
+// The one exception: the verb %c always scans the next rune in the
+// input, even if it is a space (or tab etc.) or newline.
func Scanf(format string, a ...interface{}) (n int, err error) {
return Fscanf(os.Stdin, format, a...)
}
@@ -1164,15 +1166,18 @@ func (s *ss) doScanf(format string, a []
if !widPresent {
s.maxWid = hugeWid
}
- s.SkipSpace()
+
+ c, w := utf8.DecodeRuneInString(format[i:])
+ i += w
+
+ if c != 'c' {
+ s.SkipSpace()
+ }
s.argLimit = s.limit
if f := s.count + s.maxWid; f < s.argLimit {
s.argLimit = f
}
- c, w := utf8.DecodeRuneInString(format[i:])
- i += w
-
if numProcessed >= len(a) { // out of operands
s.errorString("too few operands for format %" +
format[i-w:])
break
Index: libgo/go/fmt/scan_test.go
===================================================================
--- libgo/go/fmt/scan_test.go (revision 229616)
+++ libgo/go/fmt/scan_test.go (working copy)
@@ -300,10 +300,13 @@ var scanfTests = []ScanfTest{
{"%2s", "sssss", &xVal, Xs("ss")},
// Fixed bugs
- {"%d\n", "27\n", &intVal, 27}, // ok
- {"%d\n", "28 \n", &intVal, 28}, // was: "unexpected newline"
- {"%v", "0", &intVal, 0}, // was: "EOF"; 0 was taken as base
prefix and not counted.
- {"%v", "0", &uintVal, uint(0)}, // was: "EOF"; 0 was taken as base
prefix and not counted.
+ {"%d\n", "27\n", &intVal, 27}, // ok
+ {"%d\n", "28 \n", &intVal, 28}, // was: "unexpected newline"
+ {"%v", "0", &intVal, 0}, // was: "EOF"; 0 was taken as base
prefix and not counted.
+ {"%v", "0", &uintVal, uint(0)}, // was: "EOF"; 0 was taken as base
prefix and not counted.
+ {"%c", " ", &uintVal, uint(' ')}, // %c must accept a blank.
+ {"%c", "\t", &uintVal, uint('\t')}, // %c must accept any space.
+ {"%c", "\n", &uintVal, uint('\n')}, // %c must accept any space.
}
var overflowTests = []ScanTest{
Index: libgo/go/internal/syscall/windows/registry/value.go
===================================================================
--- libgo/go/internal/syscall/windows/registry/value.go (revision 229616)
+++ libgo/go/internal/syscall/windows/registry/value.go (working copy)
@@ -310,7 +310,6 @@ loopItems:
break
}
if err == syscall.ERROR_MORE_DATA {
- println(len(buf), l)
// Double buffer size and try again.
l = uint32(2 * len(buf))
buf = make([]uint16, l)
Index: libgo/go/net/cgo_solaris.go
===================================================================
--- libgo/go/net/cgo_solaris.go (revision 229616)
+++ libgo/go/net/cgo_solaris.go (working copy)
@@ -7,7 +7,7 @@
package net
/*
-#cgo LDFLAGS: -lsocket -lnsl
+#cgo LDFLAGS: -lsocket -lnsl -lsendfile
#include <netdb.h>
*/
Index: libgo/go/net/http/httputil/reverseproxy.go
===================================================================
--- libgo/go/net/http/httputil/reverseproxy.go (revision 229616)
+++ libgo/go/net/http/httputil/reverseproxy.go (working copy)
@@ -105,7 +105,7 @@ type requestCanceler interface {
}
type runOnFirstRead struct {
- io.Reader
+ io.Reader // optional; nil means empty body
fn func() // Run before first Read, then set to nil
}
@@ -115,6 +115,9 @@ func (c *runOnFirstRead) Read(bs []byte)
c.fn()
c.fn = nil
}
+ if c.Reader == nil {
+ return 0, io.EOF
+ }
return c.Reader.Read(bs)
}
Index: libgo/go/net/http/httputil/reverseproxy_test.go
===================================================================
--- libgo/go/net/http/httputil/reverseproxy_test.go (revision 229616)
+++ libgo/go/net/http/httputil/reverseproxy_test.go (working copy)
@@ -7,6 +7,7 @@
package httputil
import (
+ "bufio"
"io/ioutil"
"log"
"net/http"
@@ -281,3 +282,41 @@ func TestReverseProxyCancellation(t *tes
t.Fatal("DefaultClient.Do() returned nil error")
}
}
+
+func req(t *testing.T, v string) *http.Request {
+ req, err := http.ReadRequest(bufio.NewReader(strings.NewReader(v)))
+ if err != nil {
+ t.Fatal(err)
+ }
+ return req
+}
+
+// Issue 12344
+func TestNilBody(t *testing.T) {
+ backend := httptest.NewServer(http.HandlerFunc(func(w
http.ResponseWriter, r *http.Request) {
+ w.Write([]byte("hi"))
+ }))
+ defer backend.Close()
+
+ frontend := httptest.NewServer(http.HandlerFunc(func(w
http.ResponseWriter, _ *http.Request) {
+ backURL, _ := url.Parse(backend.URL)
+ rp := NewSingleHostReverseProxy(backURL)
+ r := req(t, "GET / HTTP/1.0\r\n\r\n")
+ r.Body = nil // this accidentally worked in Go 1.4 and below,
so keep it working
+ rp.ServeHTTP(w, r)
+ }))
+ defer frontend.Close()
+
+ res, err := http.Get(frontend.URL)
+ if err != nil {
+ t.Fatal(err)
+ }
+ defer res.Body.Close()
+ slurp, err := ioutil.ReadAll(res.Body)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if string(slurp) != "hi" {
+ t.Errorf("Got %q; want %q", slurp, "hi")
+ }
+}
Index: libgo/go/net/lookup.go
===================================================================
--- libgo/go/net/lookup.go (revision 229616)
+++ libgo/go/net/lookup.go (working copy)
@@ -123,6 +123,9 @@ func lookupIPDeadline(host string, deadl
// LookupPort looks up the port for the given network and service.
func LookupPort(network, service string) (port int, err error) {
+ if n, i, ok := dtoi(service, 0); ok && i == len(service) {
+ return n, nil
+ }
return lookupPort(network, service)
}
Index: libgo/go/net/port_test.go
===================================================================
--- libgo/go/net/port_test.go (revision 229616)
+++ libgo/go/net/port_test.go (working copy)
@@ -27,6 +27,7 @@ var portTests = []struct {
{"tcp", "time", 37, true},
{"tcp", "domain", 53, true},
{"tcp", "finger", 79, true},
+ {"tcp", "42", 42, true},
{"udp", "echo", 7, true},
{"udp", "tftp", 69, true},
@@ -36,6 +37,7 @@ var portTests = []struct {
{"udp", "ntp", 123, true},
{"udp", "snmp", 161, true},
{"udp", "syslog", 514, true},
+ {"udp", "42", 42, true},
{"--badnet--", "zzz", 0, false},
{"tcp", "--badport--", 0, false},
Index: libgo/go/runtime/extern.go
===================================================================
--- libgo/go/runtime/extern.go (revision 229616)
+++ libgo/go/runtime/extern.go (working copy)
@@ -47,6 +47,9 @@ It is a comma-separated list of name=val
that allow the garbage collector to avoid repeating a stack scan during
the
mark termination phase.
+ gcstackbarrierall: setting gcstackbarrierall=1 installs stack barriers
+ in every stack frame, rather than in exponentially-spaced frames.
+
gcstoptheworld: setting gcstoptheworld=1 disables concurrent garbage
collection,
making every garbage collection a stop-the-world event. Setting
gcstoptheworld=2
also disables concurrent sweeping after the garbage collection finishes.
Index: libgo/go/runtime/gc_test.go
===================================================================
--- libgo/go/runtime/gc_test.go (revision 229616)
+++ libgo/go/runtime/gc_test.go (working copy)
@@ -471,4 +471,21 @@ func testAssertVar(x interface{}) error
return nil
}
+func TestAssertE2T2Liveness(t *testing.T) {
+ *runtime.TestingAssertE2T2GC = true
+ defer func() {
+ *runtime.TestingAssertE2T2GC = false
+ }()
+
+ poisonStack()
+ testIfaceEqual(io.EOF)
+}
+
+func testIfaceEqual(x interface{}) {
+ if x == "abc" {
+ // Prevent inlining
+ panic("")
+ }
+}
+
*/
