On Thu, Oct 22, 2015 at 09:47:23AM -0700, Steve Ellcey  wrote:
> OK to checkin?

> 2015-10-21  Steve Ellcey  <sell...@imgtec.com>
>           Andrew Pinski  <apin...@cavium.com>
> 
>       PR rtl-optimization/67736
>       * combine.c (simplify_comparison): Use gen_lowpart_or_truncate instead
>       of gen_lowpart when we had a truncating and.

This is okay for mainline, and the release branches after the usual delay
and watching for fallout.

> 2015-10-21  Steve Ellcey  <sell...@imgtec.com>
>           Andrew Pinski  <apin...@cavium.com>
> 
>       PR rtl-optimization/67736
>       * gcc.dg/torture/pr67736.c: New test.
>       * gcc.dg/combine-subregs.c: New test.

One nit and maybe a problem:

> --- a/gcc/testsuite/gcc.dg/combine-subregs.c
> +++ b/gcc/testsuite/gcc.dg/combine-subregs.c
> @@ -0,0 +1,36 @@
> +/* { dg-do run } */
> +/* { dg-options "-O2 -fexpensive-optimizations" } */

-fexpensive-optimizations is default at -O2.

> +
> +#include <inttypes.h>

Does every target have that header?  Shouldn't it be <stdint.h>?

> --- a/gcc/testsuite/gcc.dg/torture/pr67736.c
> +++ b/gcc/testsuite/gcc.dg/torture/pr67736.c
> @@ -0,0 +1,32 @@
> +/* { dg-do run } */
> +
> +#include <stdlib.h>
> +

And here you don't need inttypes at all?  Confused.


Segher

Reply via email to