On Thu, Sep 03, 2015 at 02:58:39PM +0000, Joseph Myers wrote: > On Wed, 2 Sep 2015, Rich Felker wrote: > > > So if __fpscr_values was the only reason for patch 1/3 in the FDPIC > > patchset, I think we can safely drop it. And patch 2/3 was already > > committed, so 3/3, the one I was originally looking at, seems to be > > all we need. It was approved at the time, so I'll proceed with merging > > it with 5.2.0. > > Well, obviously if trying dropping patch 1/3 you need to remove everything > related to use_initial_val (the feature added in patch 1/3) from patch > 3/3.
As far as I can tell, the only "use" of use_initial_val is defining the pseudo-instruction in the md file, which causes the code in patch 1/3 to use it. I see no other references to it. As I understand, the breakage from not having it (in the original 4.5-era patch) would be when introducing references to __fpscr_values later, and no longer having the GOT pointer, but that code is gone now. Rich
