On 9 August 2015 at 16:29, Joseph Myers <jos...@codesourcery.com> wrote:
> On Sat, 8 Aug 2015, Manuel López-Ibáñez wrote:
>
>> The argument to EnabledBy() must be one or more options with the
>> Common flag, otherwise the setting is silently ignored. This patch
>> detects this case when generating the options.c file and gives an
>> appropriate error. There were two options suffering from this: -Wchkp
>> is fixed by using LangEnabledBy instead, but -Wnull-dereference cannot
>> be enabled by -Wall or -Wextra because it triggers false positives
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351#c35)
>>
>> Bootstrapped and regression tested on x86_64-linux-gnu.
>>
>> OK?
>
> OK with the requirement that the options have the Common flag being added
> to the documentation of EnabledBy in options.texi.
Done. Committed as https://gcc.gnu.org/r226751

Cheers,

Manuel.

Reply via email to