On Jul 24, 2015, "H.J. Lu" <hjl.to...@gmail.com> wrote:

> On Fri, Jul 24, 2015 at 10:53 AM, Alexandre Oliva <aol...@redhat.com> wrote:
>> On Jul 24, 2015, "H.J. Lu" <hongjiu...@intel.com> wrote:
>> 
>>> Static chain returned from get_rtl_for_parm_ssa_default_def may not
>>> have Pmode.  This patch converts static chain to Pmode if needed.
>>> Tested on Linux/x86-64.  OK for trunk?
>> 
>> Yeah, this looks good to me, thanks.  Even the static chain parm_decl
>> undergoes promotion through promote_decl_mode.  I'd have placed the test
>> and convert_to_mode call as an else to the if (!local), though.  Ok with
>> that change too.
>> 

> I tried it and it doesn't work due to

>      mark_reg_pointer (local, TYPE_ALIGN (TREE_TYPE (TREE_TYPE (parm))));

> mark_reg_pointer won't take a SUBREG.  That is why I placed it after
> mark_reg_pointer .  Is my orginal patch OK?

Aah!  Yes, thanks, I will fold it into a future updated version of the
patch for PR64164.

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer

Reply via email to