On 07/20/2011 03:30 PM, Tobias Burnus wrote:
This patch partially undoes the change done in PR 46010.

For that patch, first (comment 7)

+ || !dtp->u.p.ionml->touched)

was added - and after not solving the problem, the complete change was (comment
9 and committed version)

+ || !dtp->u.p.ionml->touched
+ || dtp->u.p.ionml->type == BT_DERIVED)


The "touched" is not needed and in fact if we are not reading derived types, it is not relevant. I should have taken it out in the first place and I suspect it tripped up the test case because "touched" uninitialized is set to zero.

I would say OK for trunk and then backport in a few weeks. If you feel like being conservative you could use

|| (dtp->u.p.ionml->type == BT_DERIVED && !dtp->u.p.ionml->touched)) but I do not think it is necessary.

Regards,

Jerry

Reply via email to