On 05/18/2015 02:07 AM, Tom de Vries wrote:
On 12-05-15 17:16, Jeff Law wrote:
[PATCH 5/5] check_GNU_style.sh: Fix tab size in 80 characters check
2015-05-11 Tom de Vries<t...@codesourcery.com>
* check_GNU_style.sh (col): Fix tab size.
OK.
Hi Jeff,
I.
I noticed a performance degradation due to this patch:
...
$ cat gcc/tree-ssa-tail-merge.c | awk '{printf "+%s\n", $0}' | time -p
./contrib/check_GNU_style.sh -
...
real 4.10
user 0.71
sys 6.77
...
Before this patch, the 'real' time was roughly a factor 80 smaller:
...
real 0.05
user 0.02
sys 0.03
...
This degradation is due to the fact that the patch does the 80 chars
check line-by-line, and invokes processes for each new line.
II.
Attached follow-up patch rewrites the 80 chars check to handle a file at
a time rather than a line at a time, and gets performance back to normal:
...
real 0.07
user 0.03
sys 0.05
...
As a bonus, the bit longer than 80 chars is now printed in red, similar
to how the other checks show the output.
OK for trunk?
Yes, this is fine.
jeff
