Hi Matthew,

> > This patch fixes an internal compiler error when micromips/nomicromips
> > attributes are used.
> >
> > The problem here was that the cached boolean attributes for the current
> > target did not agree with the uncached attributes throwing an assertion
> > error.
> >
> > It appears that saving and restoring the state for micromips was
> > missing, just like there is for mips16. OK to apply?
> 
> Just to check, the reason we don't see this in the current testsuite is that
> there is no test with both MIPS and microMIPS functions?

Correct.  The testsuite either tests microMIPS or MIPS but not both in the same 
TU.

> > gcc/
> >     * config/mips/mips.c (micromips_globals): New variable.
> >     (mips_set_compression_mode): Save and reinitialize target-dependent
> >     state for microMIPS.
> >
> > gcc/testsuite
> >     * gcc.target/mips/umips-attr.c: New test.
> 
> OK.

Committed as r223294.

Regards,
Robert

Reply via email to