On Wed, 22 Jun 2011 16:41:36 -0400 Diego Novillo <dnovi...@google.com> wrote: > > You keep overgeneralizing and I think it is misleading. > > Existing reviewers will object to certain renames and/or cleanups when > they do not see a compelling value proposition. If you think that > your change brings value, but the maintainer does not see it, it may > be a sign that you have not described the change properly.
I tend to agree, with an important caveat. Cosmetic changes (like renaming attribs.c to attributes.c) have much more subjective value to newcomers or GCC newbies than to GCC gurus. Any person working for several years on GCC (and that includes even me) don't care that much about attribs.c vs attributes.c, but a newbie will care a big lot. For us, the change don't bring much, we all have read the start of attribs.c files. For a newbie, the change will bring value. This is subjective! I am more near to "newbie" state that Richie or you Diego are. So I probably understand more their particular feelings and not being a native English speaker also helps a big lot :-) BTW, GCC development favors small patches, and that is a big bias. Cheers. -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} ***
