On Fri, May 27, 2011 at 2:25 PM, Rainer Orth
<r...@cebitec.uni-bielefeld.de> wrote:
>> Please find attached the patch that introduces %p to output only the
>> raw symbol name. @plt is added "manually", since it doesn't really
>> follow -fpic flag.
>
> Thanks, that almost did it:
>
> * HAVE_AS_IX86_{TLSGDPLT, TLSLDMPLT} are always defined as 0/1, so we
> need if, not #ifdef.
There is no need to always define it. Please simplify your
configure.ac check, see i.e. check for sahf mnemonic in configure.ac.
> * The @tlsldmplt TARGET_SUN_TLS test was inverted.
Uh, yes... I have used it during testing and forgot to remove inverted check.
> The patch below has just been bootstrapped on i386-pc-solaris2.11 with
> both Sun as (which supports both relocs) and gas (which supports none).
>
> With Sun as, all run-{gd, ld}.c failures are gone, with GNU as, the
> 32-bit run-ld.c failures remain, as expected. I'll next try to get
> @tls{gd, ldm}plt support into gas.
>
> Ok for mainline now?
Please change the check in configure.ac to conditionally define
HAVE_AS_IX86_... defines.
The patch is OK with this change.
Thanks,
Uros.
