On Mon, May 23, 2011 at 10:42 PM, Nathan Froyd <froy...@codesourcery.com> wrote: > On 05/23/2011 04:23 PM, Richard Guenther wrote: >>> So I don't buy Richie's argument. Otherwise, someone would propose a >>> patch to remove the hundreds of debug_ declarations in public header >>> files (i.e. those visible to plugins), and if he did, I hope such a >>> naughty patch won't be accepted. >> >> Such a patch would be pre-approved by me ;) Watch for not breaking >> -Wstrict-prototypes and move them to their respective .c file. > > JFTR, the reason some of the prototypes are in headers are that they are > *gasp* needed by multiple files in GCC (debug_tree comes to mind). Removing > the ones that aren't so needed would be useful, but you can't delete them all > willy-nilly.
You can surely move those to a debug-functions.h file. debug_tree is probably an example of misuse as well - we have a nearly perfect print_node which should be used by other debug functions. Richard. > -Nathan > > > >
