On Mon, May 23, 2011 at 10:33:55AM +0200, Piervit wrote:
> 
> Here is a two lines patch, allowing to use debug_dominance_info and
> debug_dominance_tree functions outside of gcc/dominance.c. 

> +extern void debug_dominance_info (enum cdi_direction dir);
> +extern void debug_dominance_tree (enum cdi_direction dir, basic_block root);
> +
>  #include "cfghooks.h"

Please put all declarations after the #include, and add a simple comment 
describing 
what the functions are doing.

With this improvement, I really hope the patch will be accepted, 
because plugins really need to be able to call all the debug printing routines. 
As I told many times, debug printing routines are more useful 
for novice plugin developers that to experts working since many years on GCC.

Regards 
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***

Reply via email to