-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/22/11 09:21, Chung-Lin Tang wrote: > This patch abstracts out a small part of simplify_comparison(), into a > new function simplify_compare_const(). The parts are basically where the > comparison RTX code and a constant operand (op1) can be simplified > towards "compare with zero". Note this part leaves op0 untouched, thus > not passed into simplify_compare_const() by reference. > > By itself this patch should only be a code reorganization, and changes > nothing to the compiler. > > This is part of a small improvement to the compare combining code in the > later patch. During before, the entire case required operand[1] of i3 to > be const0_rtx, now we can try a little tweaking of the code and > constant, and see if it then changes to a cmp zero. > > This abstracted patch was bootstrapped and tested independently on i686, > to be sure it was only a reorg. A reasonable cleanup.
I would suggest a minor addition the comment before simplify_compare_const. Specifically, the comment should say something about the return value, including modification of *pop1. Consider the patch pre-approved with the comment addition. Thanks, Jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNtasTAAoJEBRtltQi2kC731QH+wbWlHiws5F1kM631+LYeq9k O+1yW926RijnIF7uMPXU/qvzXS7ipAXjoqp54LJUv2aU453nh2Pyq45CulAZWnVF iUZmb8PHk1GP9yDwHnOh15WHHDQmVzxLyOxodG9JmGR+oRskGmTQhdj0oNh3OMG7 7TsnXLSQqLpZg2XYxp7u8QOKSeG3X4gXwMFJdwii/ihuES4l8M4QemnpCXYDe+Tl ZNyAWmeCW1833pk41vFEorWA3jFogminJy3gijJkxKsGjJME0eVtXSpCeGQfA4cg ifJMyQmVI58h/f95lmNqzXxwVWQPkkKfOvfcC2QmM8PwXHjD4JziostNtKsmbqg= =E/b1 -----END PGP SIGNATURE-----
